Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Matter protocol: add Group Communication #19954

Merged
merged 1 commit into from
Jan 17, 2025
Merged

doc: Matter protocol: add Group Communication #19954

merged 1 commit into from
Jan 17, 2025
+272 −0

Conversation

peknis
Copy link
Contributor

@peknis peknis commented Jan 16, 2025

Describing how to set up Group Communication
between the controller and a sample in the Matter
protocol documentation.

ref: KRKNWK-17365

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jan 16, 2025
@peknis peknis added the CI-disable Disable CI for this PR label Jan 16, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 16, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 16

Inputs:

Sources:

more details

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (0)

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@peknis peknis force-pushed the matter_group_comms branch 3 times, most recently from 4c1fb2c to 47b2107 Compare January 16, 2025 14:22
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 16, 2025
@peknis peknis marked this pull request as ready for review January 16, 2025 14:27
@peknis peknis requested review from a team as code owners January 16, 2025 14:27
@peknis peknis requested review from LuDuda and doublemis1 January 16, 2025 14:28
doublemis1
doublemis1 reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@doublemis1 doublemis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide suggestions about changing the sections

doc/nrf/protocols/matter/overview/group_communication.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/overview/group_communication.rst Show resolved Hide resolved
doc/nrf/protocols/matter/overview/group_communication.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/overview/group_communication.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/overview/group_communication.rst Outdated Show resolved Hide resolved
doc/nrf/protocols/matter/overview/group_communication.rst Show resolved Hide resolved
@peknis peknis force-pushed the matter_group_comms branch from 47b2107 to e0f7011 Compare January 17, 2025 07:21
@peknis peknis requested a review from a team as a code owner January 17, 2025 07:21
@peknis peknis requested a review from doublemis1 January 17, 2025 08:01
@peknis peknis force-pushed the matter_group_comms branch from e0f7011 to d6a3ae2 Compare January 17, 2025 08:19
@peknis peknis requested a review from umapraseeda January 17, 2025 08:20
doublemis1
doublemis1 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@doublemis1 doublemis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you for preparing document

@peknis peknis force-pushed the matter_group_comms branch 3 times, most recently from 630c06d to d1d3d26 Compare January 17, 2025 11:45
@peknis peknis requested a review from kkasperczyk-no January 17, 2025 11:46
@peknis peknis force-pushed the matter_group_comms branch from d1d3d26 to 246c550 Compare January 17, 2025 12:01
@peknis peknis force-pushed the matter_group_comms branch from 246c550 to 2b253af Compare January 17, 2025 13:00
@peknis peknis requested a review from kkasperczyk-no January 17, 2025 13:00
@peknis peknis force-pushed the matter_group_comms branch 4 times, most recently from 078160c to 420abe1 Compare January 17, 2025 13:18
kkasperczyk-no
kkasperczyk-no approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@kkasperczyk-no kkasperczyk-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment to be fixed, please. Beside of that everything looks good 👍

doc/nrf/protocols/matter/overview/group_communication.rst Outdated Show resolved Hide resolved
@peknis
doc: Matter protocol: add Group Communication
a79120a 
Describing how to set up Group Communication
between the controller and a sample in the Matter
protocol documentation.

ref: KRKNWK-17365

Signed-off-by: Pekka Niskanen <[email protected]>
@peknis peknis force-pushed the matter_group_comms branch from 420abe1 to a79120a Compare January 17, 2025 13:34
@rlubos rlubos merged commit 8fdaf7e into nrfconnect:main Jan 17, 2025
13 checks passed
@peknis peknis deleted the matter_group_comms branch January 17, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doublemis1 doublemis1 doublemis1 approved these changes

@kkasperczyk-no kkasperczyk-no kkasperczyk-no approved these changes

@umapraseeda umapraseeda umapraseeda approved these changes

@nordicjm nordicjm nordicjm approved these changes

@LuDuda LuDuda Awaiting requested review from LuDuda

Assignees
No one assigned
Labels
CI-disable Disable CI for this PR doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@peknis @NordicBuilder @nordicjm @umapraseeda @doublemis1 @kkasperczyk-no @rlubos